os/kstore: fix u64 decode checks

Signed-off-by: Sage Weil <[email protected]>
jsaintro · Jan 18, 2016 · 3286106 · 3286106
1 parent f8ea3eb
commit 3286106
Showing 1 changed file with 0 additions and 8 deletions.
diff --git a/src/os/kstore/KStore.cc b/src/os/kstore/KStore.cc
@@ -302,19 +302,13 @@ static int get_key_object(const string& key, ghobject_t *oid)
   const char *p = key.c_str();
 
   p = _key_decode_shard(p, &oid->shard_id);
-  if (!*p)
-    return -2;
 
   uint64_t pool;
   p = _key_decode_u64(p, &pool);
-  if (!*p)
-    return -3;
   oid->hobj.pool = pool - 0x8000000000000000ull;
 
   unsigned hash;
   p = _key_decode_u32(p, &hash);
-  if (!*p)
-    return -4;
   oid->hobj.set_bitwise_key_u32(hash);
   if (*p != '.')
     return -5;
@@ -351,8 +345,6 @@ static int get_key_object(const string& key, ghobject_t *oid)
   }
 
   p = _key_decode_u64(p, &oid->hobj.snap.val);
-  if (!*p)
-    return -11;
   p = _key_decode_u64(p, &oid->generation);
   if (*p) {
     // if we get something other than a null terminator here,