Skip to content

Commit

Permalink
Fix #70. The CurrentStep can be null.
Browse files Browse the repository at this point in the history
  • Loading branch information
jsgoupil committed Jun 6, 2023
1 parent d35c331 commit 5ce3a40
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions src/WebConnector.AspNetCore/QbManager.cs
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ protected internal virtual Task<string> GetCompanyFileAsync(IAuthenticatedTicket
/// </summary>
/// <param name="step">Step name.</param>
/// <returns>A IStepQueryRequest.</returns>
protected internal IStepQueryRequest? FindStepRequest(string step)
protected internal IStepQueryRequest? FindStepRequest(string? step)
{
if (string.IsNullOrEmpty(step))
{
Expand All @@ -567,7 +567,7 @@ protected internal virtual Task<string> GetCompanyFileAsync(IAuthenticatedTicket
/// </summary>
/// <param name="step">Step name.</param>
/// <returns>A IStepQueryResponse.</returns>
protected internal IStepQueryResponse? FindStepResponse(string step)
protected internal IStepQueryResponse? FindStepResponse(string? step)
{
if (string.IsNullOrEmpty(step))
{
Expand All @@ -582,7 +582,7 @@ protected internal virtual Task<string> GetCompanyFileAsync(IAuthenticatedTicket
/// </summary>
/// <param name="step">Step name.</param>
/// <returns>The next step name or null if none.</returns>
protected internal string FindNextStepName(string step)
protected internal string FindNextStepName(string? step)
{
var hasStep = false;
using var enumerator = stepRequest.GetEnumerator();
Expand Down
2 changes: 1 addition & 1 deletion src/WebConnector.AspNetCore/WebConnector.AspNetCore.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<Author>Jean-Sébastien Goupil</Author>
<Authors>Jean-Sébastien Goupil</Authors>
<Copyright>Copyright © Jean-Sébastien Goupil 2015-2021</Copyright>
<Version>3.1.2</Version>
<Version>3.1.3</Version>
<AssemblyName>QbSync.WebConnector.AspNetCore</AssemblyName>
<RootNamespace>QbSync.WebConnector.AspNetCore</RootNamespace>
<PackageId>QbSync.WebConnector.AspNetCore</PackageId>
Expand Down
2 changes: 1 addition & 1 deletion src/WebConnector/Core/AuthenticatedTicket.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ public interface IAuthenticatedTicket
/// <summary>
/// State indicating what to exchange with the Web Connector.
/// </summary>
string CurrentStep { get; set; }
string? CurrentStep { get; set; }

/// <summary>
/// Simple boolean indicating if the ticket is authenticated.
Expand Down
2 changes: 1 addition & 1 deletion src/WebConnector/WebConnector.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<Author>Jean-Sébastien Goupil</Author>
<Authors>Jean-Sébastien Goupil</Authors>
<Copyright>Copyright © Jean-Sébastien Goupil 2015-2021</Copyright>
<Version>3.1.2</Version>
<Version>3.1.3</Version>
<AssemblyName>QbSync.WebConnector</AssemblyName>
<RootNamespace>QbSync.WebConnector</RootNamespace>
<PackageId>QbSync.WebConnector</PackageId>
Expand Down
4 changes: 2 additions & 2 deletions test/WebApplication.Sample/Db/ApplicationDbContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,15 @@ public class QbKvpState
public string Ticket { get; set; } = default!;
public string Key { get; set; } = default!;
public string? Value { get; set; }
public string CurrentStep { get; set; } = default!;
public string? CurrentStep { get; set; }
}

public class QbTicket : IAuthenticatedTicket
{
[Key]
public string Ticket { get; set; } = default!;

public string CurrentStep { get; set; } = default!;
public string? CurrentStep { get; set; }

public bool Authenticated { get; set; }

Expand Down

0 comments on commit 5ce3a40

Please sign in to comment.