Merge pull request ampproject#2385 from mkhatib/amp-yt-lazy

Render amp-youtube lazily.
jsit · Mar 2, 2016 · 0f6c15a · 0f6c15a
2 parents 95ee178 + 0e81baa
commit 0f6c15a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/extensions/amp-youtube/0.1/amp-youtube.js b/extensions/amp-youtube/0.1/amp-youtube.js
@@ -38,6 +38,11 @@ class AmpYoutube extends AMP.BaseElement {
     return isLayoutSizeDefined(layout);
   }
 
+  /** @override */
+  renderOutsideViewport() {
+    return false;
+  }
+
   /** @override */
   buildCallback() {
     const width = this.element.getAttribute('width');

diff --git a/extensions/amp-youtube/0.1/test/test-amp-youtube.js b/extensions/amp-youtube/0.1/test/test-amp-youtube.js
@@ -182,6 +182,5 @@ describe('amp-youtube', () => {
       yt.implementation_.documentInactiveCallback();
       expect(yt.implementation_.pauseVideo_.called).to.be.true;
     });
-
   });
 });
-Original file line number
+Diff line change
@@ Expand Up / @@ -182,6 +182,5 @@ describe('amp-youtube', () => { @@
           yt.implementation_.documentInactiveCallback();
           expect(yt.implementation_.pauseVideo_.called).to.be.true;
         });
       });
     });