Skip to content

Return error codes #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Return error codes #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
870fd07
Returns code on active model validation error.
Oct 9, 2018
b15930b
Returns code on active model validation error.
Oct 9, 2018
8564c90
Add content negotiation middleware + fix response content type.
beauby Sep 15, 2017
ebdd763
Adding with_indiferent_access to controller params
Nov 10, 2017
fa85235
Teach generator to respect namespaces
alsemyonov Oct 24, 2018
1a9cd6a
Fix serializable type for namespaced models
alsemyonov Oct 24, 2018
7241389
Prepare for v0.4.0 release
dawidof Mar 7, 2019
0fc3f8c
Test against multiple rails versions.
beauby Sep 6, 2017
a911a10
Fix tests
dawidof Mar 10, 2019
e06449e
Fix JSON fragments caching.
beauby Nov 17, 2017
50ea32c
Make SerializableGenerator to check that given model exists
pjmartorell Apr 14, 2019
b301de5
Merge branch 'master' into return-jsonapi-code-on-error
Dec 10, 2020
08e5283
Refactor and fix tests.
Dec 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions lib/jsonapi/rails/serializable_active_model_errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ module JSONAPI
module Rails
# @private
class SerializableActiveModelError < Serializable::Error
code do
@code
end

title do
"Invalid #{@field}" unless @field.nil?
end
Expand All @@ -26,10 +30,13 @@ def initialize(exposures)

def as_jsonapi
@errors.keys.flat_map do |key|
@errors.full_messages_for(key).map do |message|
SerializableActiveModelError.new(field: key, message: message,
pointer: @reverse_mapping[key])
.as_jsonapi
@errors.full_messages_for(key).map.with_index do |message, i|
SerializableActiveModelError.new(
field: key,
message: message,
pointer: @reverse_mapping[key],
code: @errors.details[key][i][:error]
).as_jsonapi
end
end
end
Expand Down
4 changes: 4 additions & 0 deletions spec/render_jsonapi_errors_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@
{
'errors' => [
{
'code' => 'blank',
'detail' => 'Name can\'t be blank',
'title' => 'Invalid name',
'source' => { 'pointer' => '/data/attributes/name' }
},
{
'code' => 'invalid',
'detail' => 'Email must be a valid email',
'title' => 'Invalid email',
'source' => { 'pointer' => '/data/attributes/email' }
Expand Down Expand Up @@ -64,11 +66,13 @@ def jsonapi_pointers
def create
errors = [
{
'code' => 'blank',
detail: 'Name can\'t be blank',
title: 'Invalid name',
source: { pointer: '/data/attributes/name' }
},
{
'code' => 'invalid',
detail: 'Email must be a valid email',
title: 'Invalid email',
source: { pointer: '/data/attributes/email' }
Expand Down