Skip to content

Fix rails 6.1 deprecation warning on ActiveModel::Errors#keys (Backward compatible) #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2021
Merged

Fix rails 6.1 deprecation warning on ActiveModel::Errors#keys (Backward compatible) #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc6875f
Bump sqlite3 version
cristianstu Apr 1, 2021
03501a0
Use active record error attribute_names intead errors.keys if available
cristianstu Apr 1, 2021
e59c7f8
Bump version
cristianstu Apr 1, 2021
e1af978
Relax sqlite dependency
cristianstu Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.4.0
0.4.1
2 changes: 1 addition & 1 deletion jsonapi-rails.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
spec.add_dependency 'jsonapi-parser', '~> 0.1.0'

spec.add_development_dependency 'rails', '~> 5.0'
spec.add_development_dependency 'sqlite3', '~> 1.3.6'
spec.add_development_dependency 'sqlite3', '~> 1.3'
spec.add_development_dependency 'rake', '~> 11.3'
spec.add_development_dependency 'rspec-rails', '~> 3.5'
spec.add_development_dependency 'with_model', '~> 2.0'
Expand Down
8 changes: 7 additions & 1 deletion lib/jsonapi/rails/serializable_active_model_errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,20 @@ def initialize(exposures)
end

def as_jsonapi
@errors.keys.flat_map do |key|
error_keys.flat_map do |key|
@errors.full_messages_for(key).map do |message|
SerializableActiveModelError.new(field: key, message: message,
pointer: @reverse_mapping[key])
.as_jsonapi
end
end
end

private

def error_keys
@errors.respond_to?(:attribute_names) ? @errors.attribute_names : @errors.keys
end
end
end
end