Skip to content

Commit

Permalink
gdbusconnection: Don't g_printerr() when exiting
Browse files Browse the repository at this point in the history
exit-on-close for a DBus connection is a completely normal thing.  On
a regular GNOME login, gdm retains the X server, but terminates the
session login bus and associated helpers like gnome-settings-dameon,
the a11y tools, etc.

I've seen several downstream reports of confusion as to what these
apparent error messages mean in the system log.  It doesn't help
that they're so obtuse.

We're also printing them to stderr, when this is not an error.

The reason this was introduced is presumably some people were confused
as to why their process exited when the system bus did.  But the
solution for that I believe is documentation, not printing stuff to
everyone's system log in normal operation.

https://bugzilla.gnome.org/show_bug.cgi?id=742386
  • Loading branch information
cgwalters committed Aug 6, 2015
1 parent 905e916 commit 66bc966
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions gio/gdbusconnection.c
Original file line number Diff line number Diff line change
Expand Up @@ -804,17 +804,6 @@ g_dbus_connection_real_closed (GDBusConnection *connection,
(flags & FLAG_INITIALIZED) != 0 &&
connection->initialization_error == NULL)
{
if (error != NULL)
{
g_printerr ("%s: Remote peer vanished with error: %s (%s, %d). Exiting.\n",
G_STRFUNC,
error->message,
g_quark_to_string (error->domain), error->code);
}
else
{
g_printerr ("%s: Remote peer vanished. Exiting.\n", G_STRFUNC);
}
raise (SIGTERM);
}
}
Expand Down

0 comments on commit 66bc966

Please sign in to comment.