fix: detectSeries third callback not passing err

jthelin · Feb 27, 2021 · 1b413e5 · 1b413e5
1 parent ea78e5f
commit 1b413e5
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/install.coffee b/src/install.coffee
@@ -518,16 +518,17 @@ class Install extends Command
       ]
 
   cloneFirstValidGitUrl: (urls, cloneDir, options, callback) ->
-    async.detectSeries urls, (url, next) =>
+    async.detectSeries(urls, (url, next) =>
       @cloneNormalizedUrl url, cloneDir, options, (error) ->
-        next(not error)
-    , (result) ->
-      if not result
+        next(null, not error)
+    , (err, result) ->
+      if err or not result
         invalidUrls = "Couldn't clone #{urls.join(' or ')}"
         invalidUrlsError = new Error(invalidUrls)
         callback(invalidUrlsError)
       else
         callback()
+    )
 
   cloneNormalizedUrl: (url, cloneDir, options, callback) ->
     # Require here to avoid circular dependency