Skip to content

Commit

Permalink
Revert "improve status title (mastodon#8596)" (mastodon#13591)
Browse files Browse the repository at this point in the history
This reverts commit 05756c9.
  • Loading branch information
ykzts authored May 3, 2020
1 parent 988b049 commit e223fd8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 13 deletions.
6 changes: 1 addition & 5 deletions app/models/status.rb
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,8 @@ def preview_card
def title
if destroyed?
"#{account.acct} deleted status"
elsif reblog?
preview = sensitive ? '<sensitive>' : text.slice(0, 10).split("\n")[0]
"#{account.acct} shared #{reblog.account.acct}'s: #{preview}"
else
preview = sensitive ? '<sensitive>' : text.slice(0, 20).split("\n")[0]
"#{account.acct}: #{preview}"
reblog? ? "#{account.acct} shared a status by #{reblog.account.acct}" : "New status by #{account.acct}"
end
end

Expand Down
12 changes: 4 additions & 8 deletions spec/models/status_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -96,20 +96,16 @@

context 'unless destroyed?' do
context 'if reblog?' do
it 'returns "#{account.acct} shared #{reblog.account.acct}\'s: #{preview}"' do
it 'returns "#{account.acct} shared a status by #{reblog.account.acct}"' do
reblog = subject.reblog = other
preview = subject.text.slice(0, 10).split("\n")[0]
expect(subject.title).to(
eq "#{account.acct} shared #{reblog.account.acct}'s: #{preview}"
)
expect(subject.title).to eq "#{account.acct} shared a status by #{reblog.account.acct}"
end
end

context 'unless reblog?' do
it 'returns "#{account.acct}: #{preview}"' do
it 'returns "New status by #{account.acct}"' do
subject.reblog = nil
preview = subject.text.slice(0, 20).split("\n")[0]
expect(subject.title).to eq "#{account.acct}: #{preview}"
expect(subject.title).to eq "New status by #{account.acct}"
end
end
end
Expand Down

0 comments on commit e223fd8

Please sign in to comment.