Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove most configuration, get this working #115

Merged
merged 9 commits into from
Dec 1, 2022

Conversation

manics
Copy link
Member

@manics manics commented Sep 15, 2022

This repo is currently broken https://discourse.jupyter.org/t/jupyterhub-deploy-docker-maintainer-update/14919

I've rewritten and simplified the repo so it should now work and be easier to maintain. However it might be better to archive this repository, and make this an example under https://github.com/jupyterhub/dockerspawner/tree/main/examples (which are also out of date- we should add some tests there).

What do you think?

@welcome
Copy link

welcome bot commented Sep 15, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@wheeldogg
Copy link

Been struggling with getting this repo running yesterday and today. Glad I found this PR as works instantly :) Makes sense to me that this should be reviewed/merged by the admin

@wheeldogg
Copy link

My only thing would be the PRs should be smaller to more easily follow and merge. There are lots of things introduced in one go. Smaller PRS are easier as incremental improvements.

@minrk
Copy link
Member

minrk commented Nov 1, 2022

It is a big PR, but this repo is pretty stale, so I think a big restart to get things back in shape is fine at the moment.

Copy link
Member

@minrk minrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead and merge if you're happy with it @manics

@manics
Copy link
Member Author

manics commented Dec 1, 2022

It's a big change.... but it works so I think this is a good place to build upon.

@manics manics merged commit b7911ca into jupyterhub:master Dec 1, 2022
@welcome
Copy link

welcome bot commented Dec 1, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@manics manics deleted the refactor branch December 1, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants