Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor update #127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor update #127

wants to merge 1 commit into from

Conversation

singer-yang
Copy link

Hello professor,

Thank you a lot for developing the awesome repo "odak", it has helped me a lot! Recently I found a minor bug in Rayleigh Sommerfeld function. My reference is Eq (9) in the paper "Modeling and propagation of near-field diffraction patterns: A more complete approach."

Best,
Xinge

@kaanaksit
Copy link
Owner

Thank you @singer-yang for bringing this one up. Please keep in mind that we mostly rely on odak.learn.wave these days but not odak.wave submodule. Thus, it is left a bit rusty and may be less polished. I will accept your changes. But I want to also ask from you to update THANKS.txt and CITATION.cff with your name in this pull request before I go ahead and accept your changes. Please also note that as I accept your commits, these updates won't be alive under pip until odak==0.2.7. Best practice here in these cases is to use the repository to install the latest and greatest in between versions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants