Skip to content

Commit

Permalink
fix: remove quotes around extension in makefile (vercel#3662)
Browse files Browse the repository at this point in the history
There was an issue with building the go binary on windows. 

Before this PR:
```
make -p
...
go-turbo".exe": internal/turbodprotocol/turbod.pb.go internal/turbodprotocol/turbod_grpc.pb.go go.mod turborepo-ffi-install
...
```

Now dropping the quotes we get the desired build target:
```
make -p
...
go-turbo.exe: internal/turbodprotocol/turbod.pb.go internal/turbodprotocol/turbod_grpc.pb.go go.mod turborepo-ffi-install
...
```
and `make go-turbo.exe` works.
  • Loading branch information
chris-olszewski authored Feb 7, 2023
1 parent c4d9170 commit 79c7158
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cli/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ TURBO_TAG = $(shell cat ../version.txt | sed -n '2 p')
EXT :=
ifeq ($(OS),Windows_NT)
UNAME := Windows
EXT = ".exe"
EXT = .exe
else
UNAME := $(shell uname -s)
endif
Expand Down

0 comments on commit 79c7158

Please sign in to comment.