Fix #152: encoding name of addresses in utf-8 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
close2
reviewed
Mar 9, 2021
| var splitData = split(convert.utf8.encode(value), availableLength); | ||
| var second = false; | ||
| for (var d in split(convert.utf8.encode(value), availableLength)) { | ||
| if (second) yield _$eolSpace; |
There was a problem hiding this comment.
was there a bug in my code?
There was a problem hiding this comment.
No, I just refactored it a bit so I can reuse some code and constants.
There was a problem hiding this comment.
I can't find the yield _$eolSpace in my old code.
But your refactoring looks good to me. (If it was in my code good. If not it will be added by your code)
|
LGTM Do you want me to wait for a 2.12 version? The null safety version would have been a perfect opportunity to change the interface. |
|
Please upgrade it to 2.12. |
Will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@close2 I fixed #152 by encoding name to utf-8+base64.
Note:
Address.sanitizedNameandsanitizedAddressfor application to override (which I need it).Address'snameandmailAddressas final, soconst Addressis possible.constto make the code a bit more efficient.Item 2 and 3 are not necessary. If you don't like it you can revoke it.