Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): Support both new and deprecated OpenTelemetry runtime metrics #1026

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Mar 8, 2025

What this PR does

This commit enables Varlog to support both new and deprecated OpenTelemetry
runtime metrics.

Previously, Varlog only supported the deprecated runtime instrumentation. This
change ensures backward compatibility by simultaneously setting the
OTEL_GO_X_DEPRECATED_RUNTIME_METRICS environment variable and using the new
version.

This enhancement allows Varlog to leverage the latest OpenTelemetry features
while maintaining compatibility with older versions, collecting more
comprehensive runtime metrics.

…e metrics

This commit enables Varlog to support both new and deprecated OpenTelemetry
runtime metrics.

Previously, Varlog only supported the deprecated runtime instrumentation. This
change ensures backward compatibility by simultaneously setting the
`OTEL_GO_X_DEPRECATED_RUNTIME_METRICS` environment variable and using the new
version.

This enhancement allows Varlog to leverage the latest OpenTelemetry features
while maintaining compatibility with older versions, collecting more
comprehensive runtime metrics.
@ijsong ijsong requested a review from hungryjang as a code owner March 8, 2025 15:25
@ijsong ijsong merged commit 6531baa into release/v0.22 Mar 8, 2025
8 checks passed
@ijsong ijsong deleted the backport/v0.22/new_and_deprecated_opentelemetry_runtime_metrics branch March 8, 2025 15:30
Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 66.91%. Comparing base (980ae3c) to head (0af1bf4).

Files with missing lines Patch % Lines
pkg/util/telemetry/metric_provider.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/v0.22    #1026      +/-   ##
=================================================
- Coverage          67.22%   66.91%   -0.32%     
=================================================
  Files                179      179              
  Lines              21593    21605      +12     
=================================================
- Hits               14516    14456      -60     
- Misses              6294     6378      +84     
+ Partials             783      771      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant