Skip to content

Commit

Permalink
cmd/link: expand a TODO comment
Browse files Browse the repository at this point in the history
CL 231397 is submitted too fast... Expand the comment to make it
a little clearer.

Change-Id: Ica9737aa7b51f97320bab74457388dcab8188370
Reviewed-on: https://go-review.googlesource.com/c/go/+/231597
Reviewed-by: Austin Clements <[email protected]>
  • Loading branch information
cherrymui committed May 1, 2020
1 parent 30f8074 commit e0e0dab
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/cmd/link/internal/ld/deadcode.go
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,10 @@ func (d *deadcodePass) flood() {
if a.Type() == goobj2.AuxGotype && !d.ctxt.linkShared {
// A symbol being reachable doesn't imply we need its
// type descriptor. Don't mark it.
// XXX we need that for GCProg generation when linking
// shared library. why?
// TODO: when -linkshared, the GCProg generation code
// seems to need it. I'm not sure why. I think it could
// just reach to the type descriptor's data without
// requiring to mark it reachable.
continue
}
d.mark(a.Sym(), symIdx)
Expand Down

0 comments on commit e0e0dab

Please sign in to comment.