Fix Proxy Example #106
Closed
Fix Proxy Example #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy class should be constructed the same way as the class it wraps. From this SO answer: "Proxy and Decorator both have the same interface as their wrapped types, but the proxy creates an instance under the hood, whereas the decorator takes an instance in the constructor." https://stackoverflow.com/a/7211706/2433572 As it stands, the proxy pattern is indistinguishable from the decorator pattern.
|
Hey, thank you for the PR but I don't agree with you on this. Although what you suggested is also a valid proxy, we can't say the one in the example wrong also. As according to the definition, proxy is just meant to mirror the functionality of a class into another class and it doesn't matter whether you create the instance inside the class or pass it to the class. The up side of having the one that we have in the readme is you can use this proxy on top of any door implementing the DoorInterface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy class should be constructed the same way as the class it wraps. From this SO answer: "Proxy and Decorator both have the same interface as their wrapped types, but the proxy creates an instance under the hood, whereas the decorator takes an instance in the constructor." https://stackoverflow.com/a/7211706/2433572
As it stands, the proxy pattern is indistinguishable from the decorator pattern.