Skip to content

Commit

Permalink
fix: Response class as alias of Request class (jina-ai#2645)
Browse files Browse the repository at this point in the history
* fix: response class as alias of request

* ci: fix 404 page generation in ci
  • Loading branch information
hanxiao authored Jun 14, 2021
1 parent 6346e84 commit 4bb9e2e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 5 deletions.
1 change: 1 addition & 0 deletions .github/workflows/cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ jobs:
rm -rf ./_build/dirhtml/
ls -la
touch .nojekyll
cp 404/index.html 404.html
echo docs2.jina.ai > CNAME
git add api cli proto
git add . && git commit -m "chore(docs): update docs due to ${{github.event_name}} on ${{github.repository}}"
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ jobs:
rm -rf ./_build/dirhtml/
ls -la
touch .nojekyll
cp 404/index.html 404.html
echo docs2.jina.ai > CNAME
git add api cli proto
git add . && git commit -m "chore(docs): update docs due to ${{github.event_name}} on ${{github.repository}}"
Expand Down
8 changes: 4 additions & 4 deletions docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,10 @@
'recommonmark',
'sphinx_markdown_tables',
'sphinx_copybutton',
'notfound.extension',
'sphinx_sitemap',
'sphinx.ext.intersphinx',
'sphinxext.opengraph',
'notfound.extension',
]

# -- Custom 404 page
Expand All @@ -95,10 +95,10 @@
'title': 'Page Not Found',
'body': '''
<h1>Page Not Found</h1>
<p>Sorry, we couldn't find that page. Error code 404. </p>
<p>You can try using the search box above or check our menu on the left hand side of this page.</p>
<p>Oops, we couldn't find that page. </p>
<p>You can try using the search box or check our menu on the left hand side of this page.</p>
<p>If neither of those options work, please create a Github issue ticket <a href="https://github.com/jina-ai/jina/">here</a>, and one of our team will respond. Please use the tag Documentation. </p>
<p>If neither of those options work, please create a Github issue ticket <a href="https://github.com/jina-ai/jina/">here</a>, and one of our team will respond. Please use the tag <pre>Documentation</pre>. </p>
''',
}
Expand Down
2 changes: 1 addition & 1 deletion jina/types/request/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ def parameters(self, value: Dict):
self._pb_body.parameters.update(value)


class Response:
class Response(Request):
"""
Response is the :class:`Request` object returns from the flow. Right now it shares the same representation as
:class:`Request`. At 0.8.12, :class:`Response` is a simple alias. But it does give a more consistent semantic on
Expand Down

0 comments on commit 4bb9e2e

Please sign in to comment.