メモアプリにログインボタンを追加 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
useLogin、LoginProviderの2つをexportしているファイルを |
firewood
reviewed
Apr 6, 2025
src/hooks/useLogin.js
Outdated
| return storedIsLoggedIn || false; | ||
| }); | ||
| const login = () => { | ||
| setIsLoggedIn((prev) => !prev); |
There was a problem hiding this comment.
(not important) この挙動なら関数名は toggleLogin などのほうが妥当かと思いました。
firewood
reviewed
Apr 6, 2025
src/hooks/useLogin.js
Outdated
| login: () => {}, | ||
| }); | ||
|
|
||
| export const LoginProvider = ({ children }) => { |
There was a problem hiding this comment.
永続化しているのはいいですね!
このコンポーネントの全体の機能は LoginProvider なので、ファイル名も LoginProvider.js の方が妥当かもと思いました。
There was a problem hiding this comment.
ファイル名をLoginProvider.js に変更しました。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
メモアプリにログインボタンに追加
できるようになること
動作確認
未ログイン状態
ログイン状態
prettier、eslint
その他