-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: when the cluster resources change, reschedule the resource templates #4456
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4456 +/- ##
==========================================
- Coverage 51.89% 51.75% -0.14%
==========================================
Files 243 243
Lines 24164 24243 +79
==========================================
+ Hits 12539 12547 +8
- Misses 10944 11014 +70
- Partials 681 682 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
881eb4f
to
b4d54a4
Compare
b4d54a4
to
e335e0f
Compare
e335e0f
to
94b6b43
Compare
@XiShanYongYe-Chang PTAL. |
/assign |
91526b0
to
4a4a413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot~
4a4a413
to
42e8884
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM, some little suggestion.
42e8884
to
a581d3b
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/cc @chaosi-zju |
…lates Signed-off-by: chaunceyjiang <[email protected]>
a581d3b
to
af21f85
Compare
New changes are detected. LGTM label has been removed. |
/cc @RainbowMango PTAL. |
/lgtm thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
case !equality.Semantic.DeepEqual(oldCluster.Status.ResourceSummary, newCluster.Status.ResourceSummary): | ||
s.clusterResourcesReconcileWorker.Enqueue(newCluster) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern is that this will make the scheduler very sensitive because the cluster's resources will be updated frequently, when there are multiple clusters, it will put a lot of pressure on the scheduler.
What I've been thinking:
- Is it reasonable for the scheduler to give up on scheduling a resource if it can not find a feasible cluster? Should the scheduler retry these tasks? such as by introducing a retry queue?
- Karmada needs a capability that allows users to trigger rescheduling. There are many scenarios where rescheduling is required, cluster resource change is just one small case.
Signed-off-by: chaunceyjiang [email protected]
What type of PR is this?
/kind feature
What this PR does / why we need it:
when the cluster resources change, reschedule the resource templates
Which issue(s) this PR fixes:
Fixes #4434
Special notes for your reviewer:
Does this PR introduce a user-facing change?: