forked from rerun-io/rerun
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce the concepts of "default" and "active" blueprint. Make rese…
…t return to default. (rerun-io#5678) ### What - Partial implementation of: - rerun-io#5583 - rerun-io#5298 - This does not yet fully track a blueprint-per-recording-id, but playing with this I think doing so might still be worth exploring. - Introduces a new "default blueprint" per app-id in the store-hub. - Changes the ActivateStore -> BlueprintReady with a mechanism to specify `make_default` and `make_active` - Introduces new python API: `send_blueprint` Important aspect of implementation: - When you click the reset button we now clone the default blueprint into a new blueprint. This way we don't modify the blueprint that is the target for the reset. Future work we need to build on top of this (Feel free to push these improvements here, or we can push to a future PR). - [x] Biggest issue. This currently breaks File->Open / Drag-and-drop since those now **just** set the default. - Proposal: we should go ahead add the "force activate" bool into the `ActivateStore` message. We should set this bool in the message when we inject it into "File->Save" pathway. That way if you manually save a blueprint, it will always load when you open it. But if you are opening an RRD file that happens to have a blueprint it will still just use the "default" behavior. - [x] Should introduce SystemCommand & UI to clear the default blueprint so resetting goes back to heuristics. Future work: - Should introduce SystemCommand & UI to set a different blueprint as the default. - rerun-io#5691 - Notification to user when default blueprint changes. Probably better as follow-on PR - rerun-io#5692 - **Make state observable** by supporting a selection of the AppId. Probably better as follow-on PR: - rerun-io#5672 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5678/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5678/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5678/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5678) - [Docs preview](https://rerun.io/preview/78935399ef8b4289c5ba6535f01e988e0cb26e70/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/78935399ef8b4289c5ba6535f01e988e0cb26e70/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
- Loading branch information
Showing
49 changed files
with
643 additions
and
213 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.