RedPen class is reverted not to use state variable, with a new valida…

…te interface
karronoli · Oct 20, 2020 · aa31d0e · aa31d0e
1 parent 4705c11
commit aa31d0e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 8 deletions.
diff --git a/redpen-cli/src/main/java/cc/redpen/Main.java b/redpen-cli/src/main/java/cc/redpen/Main.java
@@ -133,7 +133,7 @@ public static int run(String... args) throws RedPenException {
         String resultFormat = "plain";
         String inputSentence = null;
         String language = "en";
-        String threshold = "info";
+        String threshold = "error";
 
         int limit = DEFAULT_LIMIT;
 

diff --git a/redpen-core/src/main/java/cc/redpen/RedPen.java b/redpen-core/src/main/java/cc/redpen/RedPen.java
@@ -46,9 +46,6 @@ public class RedPen {
     private final SentenceExtractor sentenceExtractor;
     private final List<Validator> validators;
 
-    private String errorLevel = "info";
-    public void setErrorLevel( String level ) { errorLevel = level; };
-
     /**
      * constructs RedPen with specified config file.
      *
@@ -143,7 +140,7 @@ public List<Document> parse(DocumentParser parser, File[] files) throws RedPenEx
      * @return list of validation errors
      */
     public Map<Document, List<ValidationError>> validate(List<Document> documents) {
-        return validate(documents, errorLevel);
+        return validate(documents, "error");
     }
 
     /**
@@ -165,12 +162,23 @@ public Map<Document, List<ValidationError>> validate(List<Document> documents, S
     }
 
     /**
-     * validate the input document collection. Note that this method call is NOT thread safe. RedPen instances need to be crated for each thread.
+     * validate the input document. Note that this method call is NOT thread safe. RedPen instances need to be crated for each thread.
      *
      * @param document document to be validated
      * @return list of validation errors
      */
     public List<ValidationError> validate(Document document) {
+        return validate(document, "error");
+    }
+
+    /**
+     * validate the input document. Note that this method call is NOT thread safe. RedPen instances need to be crated for each thread.
+     *
+     * @param document document to be validated
+     * @param threshold threshold of error level
+     * @return list of validation errors
+     */
+    public List<ValidationError> validate(Document document, String threshold) {
         List<Document> documents = new ArrayList<>();
         documents.add(document);
         Map<Document, List<ValidationError>> documentListMap = validate(documents);

diff --git a/redpen-server/src/main/java/cc/redpen/server/api/RedPenResource.java b/redpen-server/src/main/java/cc/redpen/server/api/RedPenResource.java
@@ -110,9 +110,8 @@ public Response validateDocument(@FormParam("document") @DefaultValue("") String
         } else {
             redPen = new RedPen(new ConfigurationLoader().secure().loadFromString(config));
         }
-        redPen.setErrorLevel( errorLevel );
         Document parsedDocument = redPen.parse(DocumentParser.of(documentParser), document);
-        List<ValidationError> errors = redPen.validate(parsedDocument);
+        List<ValidationError> errors = redPen.validate(parsedDocument, errorLevel);
 
         Formatter formatter = FormatterUtils.getFormatterByName(format);