Don't allow saving dashboard with empty name

karthikrk1 · Jun 28, 2017 · e543e0c · e543e0c
1 parent 92f93f8
commit e543e0c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/client/app/pages/dashboards/edit-dashboard-dialog.html b/client/app/pages/dashboards/edit-dashboard-dialog.html
@@ -17,5 +17,5 @@ <h4 class="modal-title">Edit: {{$ctrl.dashboard.name}}</h4>
 </div>
 <div class="modal-footer">
   <button type="button" class="btn btn-default" ng-disabled="$ctrl.saveInProgress" ng-click="$ctrl.dismiss()">Close</button>
-  <button type="button" class="btn btn-primary" ng-disabled="$ctrl.saveInProgress" ng-click="$ctrl.saveDashboard()">Save</button>
+  <button type="button" class="btn btn-primary" ng-disabled="$ctrl.saveInProgress || !$ctrl.isFormValid()" ng-click="$ctrl.saveDashboard()">Save</button>
 </div>
diff --git a/client/app/pages/dashboards/edit-dashboard-dialog.js b/client/app/pages/dashboards/edit-dashboard-dialog.js
@@ -1,4 +1,4 @@
-import { sortBy } from 'underscore';
+import { isEmpty, sortBy } from 'underscore';
 import template from './edit-dashboard-dialog.html';
 
 const EditDashboardDialog = {
@@ -45,6 +45,8 @@ const EditDashboardDialog = {
       });
     }
 
+    this.isFormValid = () => !isEmpty(this.dashboard.name);
+
     this.saveDashboard = () => {
       this.saveInProgress = true;