fix for better escaping to avoid SQL injections #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not perfect and will likely fail in some cases, first proposal |
|
Could you write tests for this? |
gavindsouza
reviewed
Sep 29, 2023
| # Did not find how to do that simply with pypika :( | ||
| return ( | ||
| value.replace("\\", r"\\") | ||
| .replace(quote_char, quote_char * 2) |
There was a problem hiding this comment.
To add something like this now, it should be configurable behind a feature flag. This gives off big breaking energy 🥲
There was a problem hiding this comment.
OK, why not, how do you see it? A default option set to escape function by default on which you can override and put a no-op one?
I am here because I saw some SQL injections on our platform, IMHO, it should be applied by default
|
Please also pull the newest code from master for the CI tests to pitch in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #238
Fix #366