Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URO-82, URO-168 Add share narrative function. #109

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

dakotablair
Copy link
Collaborator

@dakotablair dakotablair commented Sep 20, 2023

This PR adds the API calls for updating sharing in the narrative control menu. This is also the final piece of functionality for the Navigator as a whole. That is, no major new functionality remains for Navigator itself. In particular, the narrative navigator is now feature complete.

  • URO-82: Create Navigator Component
    • Aligns roughly to mockup URO-78.
    • Implement user behaviors existing in previous Navigator
    • Manages state for searches and filters
    • Manages quantity of search results displayed
    • Manages state for the control menu including
      • delete
      • copy
      • link (to an organization)
      • rename
      • restore
      • share
    • Handles narrative metadata changes at least to the standard of the previous Navigator
  • URO-168: Add API calls to the Share Narrative action in the control menu.
    • Narratives can be shared (Narrative permissions of a specified level can be assigned to a specified user) using the Narrative Control Menu. Specifically narrative admins may:
      • Add a new user with selected permissions
      • Remove a user from shares
      • Update a user's permission level
      • Make a narrative globally public or private
    • If the action fails then this is shown to the user using a toast notification. Have distinct messages for when:
      • The app cannot confirm action success.

This includes:

- Adding a new user with selected permissions
- Removing a user from shares
- Updating a user's permission level
- Making a narrative globally public or private
Copy link
Collaborator

@dauglyon dauglyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments, but everything LGTM

@dakotablair dakotablair merged commit 0f90f2f into main Sep 28, 2023
@dakotablair dakotablair deleted the navigator branch September 28, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants