Update lints for Flutter 3.24

kee-org · Aug 16, 2024 · 242e4b6 · 242e4b6
1 parent 896ca12
commit 242e4b6
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/analysis_options.yaml b/analysis_options.yaml
@@ -36,6 +36,7 @@ analyzer:
   errors:
     todo: ignore
     prefer_const_constructors: ignore # until an automated fix can resolve hundreds of issues
+    deprecated_member_use: ignore # until upgrade to MD3 components, colours, etc.
   exclude:
     - lib/generated/**
     - lib/phonetic.dart

diff --git a/lib/widgets/account_create.dart b/lib/widgets/account_create.dart
@@ -797,7 +797,7 @@ class AccountCreateWrapperWidget extends StatelessWidget {
         ),
         body: PopScope(
           canPop: skipBackCheck,
-          onPopInvoked: (bool didPop) async {
+          onPopInvokedWithResult: (bool didPop, Object? result) async {
             if (didPop) {
               return;
             }

diff --git a/lib/widgets/entry.dart b/lib/widgets/entry.dart
@@ -342,7 +342,7 @@ class EntryWidget extends StatelessWidget {
                       ),
                 body: PopScope(
                   canPop: !entry.isDirty,
-                  onPopInvoked: (bool didPop) async {
+                  onPopInvokedWithResult: (bool didPop, Object? result) async {
                     if (didPop) {
                       return;
                     }

diff --git a/lib/widgets/kee_vault_app.dart b/lib/widgets/kee_vault_app.dart
@@ -120,6 +120,10 @@ class KeeVaultAppState extends State<KeeVaultApp> with WidgetsBindingObserver, T
         l.e('Nav context unexpectedly missing. Autofill navigation is likely to fail in strange ways.');
         return;
       }
+      if (!navContext.mounted) {
+        l.e('Nav context unexpectedly unmounted. Autofill navigation is likely to fail in strange ways.');
+        return;
+      }
       final mode = intent?.extra?['autofill_mode'];
       if (mode?.startsWith('/autofill') ?? false) {
         BlocProvider.of<AutofillCubit>(navContext).refresh();