Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cel query gets empty after opening alert modal in keep UI #3838

Merged
merged 4 commits into from
Mar 4, 2025
Merged

fix: Cel query gets empty after opening alert modal in keep UI #3838

merged 4 commits into from
Mar 4, 2025

Conversation

skynetigor
Copy link
Contributor

Closes #2985

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@vercel Vercel
Copy link

vercel bot commented Mar 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 0:43am

@skynetigor skynetigor closed this Mar 4, 2025
@skynetigor skynetigor reopened this Mar 4, 2025
@skynetigor skynetigor marked this pull request as ready for review March 4, 2025 12:36
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working UI User interface related issues labels Mar 4, 2025
@skynetigor skynetigor merged commit d84d5d3 into main Mar 4, 2025
17 of 20 checks passed
@skynetigor skynetigor deleted the 2985_CEL-query-gets-empty-after-opening-alert-modal-in-keep-ui branch March 4, 2025 12:52
@sentry-io Sentry.io
Copy link

sentry-io bot commented Mar 16, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceError: window is not defined /alerts/[id] View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matvey-Kuk Matvey-Kuk Matvey-Kuk approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: CEL query gets empty after opening alert modal in keep-ui
2 participants
@skynetigor @Matvey-Kuk