fix: Refactor timestamp handling for incident alerts #3856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Update incident start and last seen times to use the "lastReceived" field from alerts instead of "timestamp". Added parsing logic for string timestamps and a test to validate the timestamp handling based on varied alert data.
This commit removes unused imports `DATETIME` and `parse` from `db.py` and `test_incidents.py` respectively. Cleaning up unused imports improves code readability and reduces unnecessary dependencies.
VladimirFilonov
force-pushed
the
fix/3822-bug-incident-started-date-is-wrong-ai-summary-doing-nothings
branch
from
966afe0 to
413190a
Compare
Matvey-Kuk
approved these changes
Mar 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3856 +/- ##
===========================================
+ Coverage 31.25% 47.55% +16.30%
===========================================
Files 70 156 +86
Lines 8307 15362 +7055
===========================================
+ Hits 2596 7306 +4710
- Misses 5711 8056 +2345 ☔ View full report in Codecov by Sentry. |
VladimirFilonov
deleted the
fix/3822-bug-incident-started-date-is-wrong-ai-summary-doing-nothings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update incident start and last seen times to use the "lastReceived" field from alerts instead of "timestamp". Added parsing logic for string timestamps and a test to validate the timestamp handling based on varied alert data.
Closes #3822
📑 Description
✅ Checks
ℹ Additional Information