Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bug when not all workflows have been displayed #3948

Merged
merged 18 commits into from
Mar 10, 2025
Merged

fix: Fix bug when not all workflows have been displayed #3948

merged 18 commits into from
Mar 10, 2025

Conversation

skynetigor
Copy link
Contributor

@skynetigor skynetigor commented Mar 10, 2025 •
edited
Loading

Closes #3936

📑 Description

  • Refactor sql query

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

skynetigor and others added 16 commits March 9, 2025 12:47
@skynetigor
fix: Add error case handling and refactor workflow query structure
ecbeb82
@skynetigor
fix: Improve workflow status handling and simplify query parameters
7c957f8
@skynetigor
fix: Restore early return for empty workflow count in get_workflows_w…
cf99233 
…ith_last_executions_v2
@Kiryous
Merge branch 'main' into fixes_after_workflow_facets_merge
7124dbc
@skynetigor
fix: Update field names for consistency and clarity in workflows
cf6428f
@skynetigor
Merge branch 'fixes_after_workflow_facets_merge' of https://github.co…
867d1ed 
…m/keephq/keep into fixes_after_workflow_facets_merge
@skynetigor
Update workflows.py
4a14a0b
@skynetigor
fix: Comment out distinct query to prevent potential issues with orde…
824bb4a 
…ring
@skynetigor
fix: Remove distinct query to address potential ordering issues
ec6ea90
@skynetigor
Fix case insensitive contains/startsWith/endsWith query for mysql
236eaf6
@skynetigor
Merge branch 'main' into fixes_after_workflow_facets_merge
5cc5f8a
@skynetigor
fix: Update enabling status logic to handle multiple truthy values
87f142e
@skynetigor
Merge branch 'fixes_after_workflow_facets_merge' of https://github.co…
1b29870 
…m/keephq/keep into fixes_after_workflow_facets_merge
@skynetigor
refactor query to fix bug with not displayed some workflows
0b0e862
@skynetigor
Merge branch 'main' into fixes_after_workflow_facets_merge
92a4e02
@skynetigor
refactor: Remove unused parameter from build_workflows_total_count_qu…
5c18a7f 
…ery function
@vercel Vercel
Copy link

vercel bot commented Mar 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 0:35am

@skynetigor skynetigor marked this pull request as ready for review March 10, 2025 12:02
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working labels Mar 10, 2025
@skynetigor skynetigor enabled auto-merge (squash) March 10, 2025 12:30
@skynetigor skynetigor merged commit 8e6fc4d into main Mar 10, 2025
16 of 18 checks passed
@skynetigor skynetigor deleted the fixes-after-workflow-facets-merge branch March 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matvey-Kuk Matvey-Kuk Matvey-Kuk approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Facets for workflows show weird results
3 participants
@skynetigor @Matvey-Kuk @Kiryous