fix: Refactor incident status change logic to incident_bl. #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separated the incident status change functionality into a dedicated method within `incident_bl` for improved modularity and readability. This reduces redundancy in `routes/incidents.py` and centralizes the business logic for incident handling. Additionally, adjusted enrichment metadata retrieval and added necessary imports for consistency.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
the
size:L
Replaced the `change_by` parameter type with `AuthenticatedEntity` in the `change_status` method to improve type consistency and clarity. Removed unused `datetime` import for cleaner code.
VladimirFilonov
deleted the
fix/4000-bug-incident-status-change-does-not-trigger-workflows
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated the incident status change functionality into a dedicated method within
incident_blfor improved modularity and readability. This reduces redundancy inroutes/incidents.pyand centralizes the business logic for incident handling. Additionally, adjusted enrichment metadata retrieval and added necessary imports for consistency.Closes #4000
📑 Description
✅ Checks
ℹ Additional Information