-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented Nagios Provider (#3960) #4091
Conversation
@deekshatomer is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
hi ! @Matvey-Kuk Could you please review this PR? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see only tests in the proposed changes, not the provider itself 😢
@Matvey-Kuk I have added the missing NagiosProvider class. Please review. |
@deekshatomer I see you wrote a |
/claim #3960
Closes #3960
Summary
Implemented the Nagios Provider for Keep.
Description:
-Added a new class NagiosProvider to integrate with Nagios.
-Implemented the fetch_alerts method to retrieve alerts from Nagios using HTTP requests.
-Created a unit test file (test_nagios_provider.py) to verify the functionality of the NagiosProvider class.
-Used unittest.mock to mock the fetch_alerts method in the test to avoid real HTTP requests.
-Verified that the test passes successfully.
Testing:
Ran the test file test_nagios_provider.py using pytest, and it passed without any issues.
Confirmed that the implementation works as expected with mocked responses.
/claim #3960