Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented Nagios Provider (#3960) #4091

Closed

Conversation

deekshatomer
Copy link

@deekshatomer deekshatomer commented Mar 18, 2025

/claim #3960
Closes #3960

Summary

Implemented the Nagios Provider for Keep.

Description:
-Added a new class NagiosProvider to integrate with Nagios.
-Implemented the fetch_alerts method to retrieve alerts from Nagios using HTTP requests.
-Created a unit test file (test_nagios_provider.py) to verify the functionality of the NagiosProvider class.
-Used unittest.mock to mock the fetch_alerts method in the test to avoid real HTTP requests.
-Verified that the test passes successfully.

Testing:
Ran the test file test_nagios_provider.py using pytest, and it passed without any issues.
Confirmed that the implementation works as expected with mocked responses.
/claim #3960

Copy link

vercel bot commented Mar 18, 2025

@deekshatomer is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 18, 2025
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added Feature A new feature Provider Providers related issues labels Mar 18, 2025
@deekshatomer deekshatomer changed the title Implemented Nagios Provider (#3960) feat: Implemented Nagios Provider (#3960) Mar 18, 2025
@deekshatomer
Copy link
Author

hi ! @Matvey-Kuk Could you please review this PR? Thanks!

Copy link
Contributor

@Matvey-Kuk Matvey-Kuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only tests in the proposed changes, not the provider itself 😢

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 18, 2025
@deekshatomer
Copy link
Author

@Matvey-Kuk I have added the missing NagiosProvider class. Please review.

@Matvey-Kuk
Copy link
Contributor

@deekshatomer I see you wrote a fetch_alerts method, but it's not following the design principles for providers. Also I see that the the documentation is missing. Will close the PR for now, please check other providers and feel free to open the PR one more time once it's ready.

@Matvey-Kuk Matvey-Kuk closed this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙋 Bounty claim Feature A new feature Provider Providers related issues size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🔌 Provider]: Nagios Provider
3 participants