Skip to content

Commit

Permalink
Remove deployments on master push
Browse files Browse the repository at this point in the history
  • Loading branch information
kamranahmedse committed Jun 6, 2024
1 parent d2e3fee commit 6644d82
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 23 deletions.
7 changes: 0 additions & 7 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
name: Deploy to EC2
on:
workflow_dispatch: # allow manual run
push:
branches:
- master
paths:
- 'src/**'
- 'public/**'
- 'editor/**'
jobs:
deploy:
runs-on: ubuntu-latest
Expand Down
16 changes: 0 additions & 16 deletions contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,11 @@

First of all thank you for considering to contribute. Please look at the details below:

- [Create a New Branch](#create-a-new-branch)
- [New Roadmaps](#new-roadmaps)
- [Existing Roadmaps](#existing-roadmaps)
- [Adding Content](#adding-content)
- [Guidelines](#guidelines)

## Create A New Branch

To create a new branch against `develop` for your contribution please do the following:

```bash
git clone https://github.com/kamranahmedse/developer-roadmap.git # Clone Repo
cd developer-roadmap # Change Directory
git switch develop && git pull # Switch and pull
git checkout -b "a-sensible-branch-name" # Create your branch
```

## New Roadmaps

For new roadmaps, you can either:
Expand Down Expand Up @@ -58,10 +46,6 @@ Visit the following resources to learn more:

## Guidelines

- <p><strong>Please open your pull request (PR) against the develop branch.</strong><br />

To keep caching and deployments under control, please open your PR's against the `develop` branch, which will then be merged into `master` at the end of the day.

- <p><strong>Adding everything available out there is not the goal!</strong><br />

The roadmaps represent the skillset most valuable today, i.e., if you were to enter any of the listed fields today, what would you learn? There might be things that are of-course being used today but prioritize the things that are most in demand today, e.g., agreed that lots of people are using angular.js today but you wouldn't want to learn that instead of React, Angular, or Vue. Use your critical thinking to filter out non-essential stuff. Give honest arguments for why the resource should be included.</p>
Expand Down

0 comments on commit 6644d82

Please sign in to comment.