New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- change .update_tab_path to be relative if path = "." for ukb_df #8

Closed

muschellij2 wants to merge 1 commit into kenhanscombe:master from muschellij2:master

Contributor

muschellij2 commented May 14, 2018

In .update_tab_path (see master...muschellij2:master#diff-a2fd55d43d2ab8edef24e51768910caeL209), if the path is set using getwd(), then this script will fail in the future run if the files are moved. Without adding in getwd(), then this script should work in the future.


- change .update_tab_path to be relative if path = "." for ukb_df

a8e8c6b

Owner

kenhanscombe commented May 17, 2018

Would it fail? I thought it would pick up the current directory on any re-run.

You're right though; getwd() is not needed. I've dropped the if construct altogether and pasted path (default path = ".") and file name.

Thanks for picking that up.

kenhanscombe closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment