This repository has been archived by the owner on Nov 26, 2020. It is now read-only.
Bump react-scripts to 1.0.7 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
reviewed
May 29, 2017
| }, | ||
| watch: { | ||
| description: 'run the integration tests in watch mode', | ||
| script: testEnv( |
There was a problem hiding this comment.
Could you remove the testEnv function declaration at the bottom of this file because it's no longer in use :)
| "jest-test-typescript-parser": "^19.0.2", | ||
| "jest-util": "^19.0.2", | ||
| "jest-validate": "^19.0.2", | ||
| "jest-glamor-react": "^1.3.0", |
| "nps": "^5.0.5", | ||
| "nps-utils": "^1.2.0", | ||
| "polished": "^1.0.3", | ||
| "pretty-format": "^19.0.0", | ||
| "pushstate-server": "^3.0.0", | ||
| "react-addons-test-utils": "15.4.2", | ||
| "react-scripts": "^0.9.4" | ||
| "react-scripts": "1.0.7" |
awesome! Thanks so much for contributing back :) |
|
Thanks for the help! I'm not sure what's up with the build so we can figure that out later |
|
EDIT: Discard cypress, it was just old version I had (basically this cypress-io/cypress#369). |
|
I'm basing this on this build. Something about |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @kentcdodds, this is a fantastic resource for organising a testing workshop, thank you!
Since I've just started using it myself to teach about testing for my fellow coworkers, I thought it would be nice to give something back.
This PR bumps
react-scriptsto the latest, which comes with Jest@20 included, so no more weird hacks needed inpackage.json😉.Because of a bug in config resolving algo in Jest, nested configs need to point to your actual root directory (basically where
process.cwd()points), hencerootDirexplicitly added to these configuration files.I've also removed
testEnv()from jest commands, since Jest is supposed to do it for you. If this doesn't work on Windows for some reasons I can revert it (and file an issue in Jest repo).