Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenVINO backend] Support numpy.argsort #20913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nikolasavic3
Copy link
Contributor

Implements the numpy.argsort operation for the Keras 3 OpenVINO backend.
Fixes #29012.

@rkazants, could you please review?

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.38%. Comparing base (1eee113) to head (10f2761).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20913      +/-   ##
==========================================
+ Coverage   82.35%   82.38%   +0.02%     
==========================================
  Files         561      561              
  Lines       52992    53072      +80     
  Branches     8207     8221      +14     
==========================================
+ Hits        43644    43725      +81     
  Misses       7337     7337              
+ Partials     2011     2010       -1     
Flag Coverage Δ
keras 82.20% <100.00%> (+0.02%) ⬆️
keras-jax 64.08% <0.00%> (-0.06%) ⬇️
keras-numpy 58.86% <0.00%> (-0.06%) ⬇️
keras-openvino 32.72% <100.00%> (+0.13%) ⬆️
keras-tensorflow 64.55% <0.00%> (-0.06%) ⬇️
keras-torch 64.13% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikolasavic3 nikolasavic3 force-pushed the openVino-sort branch 6 times, most recently from 87a2c2d to ea65e1f Compare February 17, 2025 15:53
@gbaned gbaned requested a review from mattdangerw February 18, 2025 11:44
@nikolasavic3 nikolasavic3 force-pushed the openVino-sort branch 3 times, most recently from 6fc1ece to c339f3a Compare February 22, 2025 11:19
@@ -10,7 +10,6 @@ NumpyDtypeTest::test_arctan2_
NumpyDtypeTest::test_argmax
NumpyDtypeTest::test_argmin
NumpyDtypeTest::test_argpartition
NumpyDtypeTest::test_argsort
Copy link
Contributor

@rkazants rkazants Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove exclusion for another test for correctness as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants