Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler event config #1974

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Scheduler event config #1974

merged 3 commits into from
Jun 30, 2023

Conversation

gctucker
Copy link
Contributor

Update the YAML config to have event attributes in the scheduler entries rather than Job.run_on as discussed on the mailing list and GitHub.

Fixes kernelci/kernelci-pipeline#221

gctucker added 3 commits June 23, 2023 09:24
@gctucker
kernelci.config: move event condition to scheduler
a4389e0 
Remove the Job.run_on list of conditions and replace it with a single
event attribute in the scheduler entries since we can already define
multiple entries for a same job.  This is as discussed on the mailing
list and GitHub.

Update unit tests accordingly.

Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Guillaume Tucker <[email protected]>
@gctucker
kernelci.scheduler: use scheduler config event attribute
34074f4 
Update the Scheduler.get_configs() implementation to rely on the event
attribute in scheduler config entries to work out which jobs to run
rather than on the Job.run_on attribute which has now been removed.
This simplifies the logic and makes it more flexible.

Signed-off-by: Guillaume Tucker <[email protected]>
@gctucker
kernelci.cli: sched: drop list_jobs command
69c52ee 
Remove the `kci sched list_jobs` command as event criteria for running
jobs is now specified in the scheduler config entries rather than in
the job configs.

Signed-off-by: Guillaume Tucker <[email protected]>
@gctucker
Copy link
Contributor Author

Tested OK on staging:

Listening for events... 
Press Ctrl-C to stop.
Time                        Commit        Node Id                   State      Result    Name
2023-06-23 07:37:47.960624  a14daf572d52  64954bcb5b4805a68b17a068  Running    -         checkout
2023-06-23 07:38:42.454629  a14daf572d52  64954bcb5b4805a68b17a068  Available  -         checkout
2023-06-23 07:38:42.567721  a14daf572d52  64954c025b4805a68b17a069  Running    -         kver
2023-06-23 07:38:42.610653  a14daf572d52  64954c025b4805a68b17a06a  Running    -         kbuild-gcc-10-x86
2023-06-23 07:38:42.634080  a14daf572d52  64954c025b4805a68b17a06b  Running    -         kunit
2023-06-23 07:38:44.730092  a14daf572d52  64954c045b4805a68b17a06c  Running    -         kunit-x86_64
2023-06-23 07:38:59.195247  a14daf572d52  64954c025b4805a68b17a069  Done       Pass      kver
2023-06-23 07:40:21.207364  a14daf572d52  64954c025b4805a68b17a06b  Done       Pass      kunit
2023-06-23 07:42:54.582110  a14daf572d52  64954c045b4805a68b17a06c  Done       Pass      kunit-x86_64
2023-06-23 07:44:14.831739  a14daf572d52  64954c025b4805a68b17a06a  Done       Pass      kbuild-gcc-10-x86
2023-06-23 07:44:14.954052  a14daf572d52  64954d4e5b4805a68b17a19d  Running    -         baseline-x86
2023-06-23 07:45:00.400240  a14daf572d52  64954d4e5b4805a68b17a19d  Done       Pass      baseline-x86
2023-06-23 07:48:48.643089  a14daf572d52  64954bcb5b4805a68b17a068  Done       -         checkout

@gctucker gctucker added this pull request to the merge queue Jun 30, 2023
Merged via the queue into kernelci:main with commit 40eb863 Jun 30, 2023
@gctucker gctucker deleted the scheduler-event-config branch June 30, 2023 12:03
@gctucker gctucker mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
KernelCI API & Pipeline
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Job configuration implementation
1 participant
@gctucker