fixed removeActivity by foreignId

kevin2314 · Nov 12, 2014 · dbb7e29 · dbb7e29
1 parent 6ef092b
commit dbb7e29
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/lib/feed.js b/src/lib/feed.js
@@ -41,6 +41,7 @@ StreamFeed.prototype = {
 	removeActivity : function(activityId, callback) {
 		/*
 		 * Removes the activity by activityId
+		 * feed.removeActivity(activityId);
 		 * Or
 		 * feed.removeActivity({'foreign_id': foreignId});
 		 */
@@ -49,9 +50,8 @@ StreamFeed.prototype = {
 		if (activityId.foreignId) {
 			params.foreign_id = '1';
 		}
-		var xhr = this.client.
-		delete ( {
-			'url' : 'feed/' + this.feedUrl + '/' + activityId + '/',
+		var xhr = this.client.delete( {
+			'url' : 'feed/' + this.feedUrl + '/' + identifier + '/',
 			'qs' : params,
 			'signature' : this.signature
 		}, callback);

diff --git a/test/integration/index.js b/test/integration/index.js
@@ -238,7 +238,12 @@ describe('Stream client', function () {
     	expect(response.statusCode).to.eql(201);
     	user1.removeActivity({foreignId: 'add:1'}, function(error, response, body) {
     		expect(response.statusCode).to.eql(200);
-    		done();
+    		user1.get({limit:10}, function(error, response, body) {
+    			expect(response.statusCode).to.eql(200);
+    			expect(body['results'][0]['id']).not.to.eql(activityId);
+    			expect(body['results'][0]['foreign_id']).not.to.eql('add:1');
+    			done();
+    		});
     	});
     }
     user1.addActivity(activity, remove);