fix dll injection / ejection not working:

fixed injection not working when dll-path has spaces fixed ejection not working by running gameluancher as admin
kherock · Nov 27, 2016 · 56edf5b · 56edf5b
1 parent 3dbd4de
commit 56edf5b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/GloSC_GameLauncher/GloSC_GameLauncher.cpp b/GloSC_GameLauncher/GloSC_GameLauncher.cpp
@@ -190,9 +190,10 @@ bool GloSC_GameLauncher::IsProcessRunning(DWORD pid)
 void GloSC_GameLauncher::unhookBindings()
 {
 	QProcess proc;
-	proc.setNativeArguments(" --process-name Steam.exe --module-name EnforceBindingDLL.dll --eject ");
+	proc.setNativeArguments(" --process-name Steam.exe --module-name \"EnforceBindingDLL.dll\" --eject ");
 	proc.start("Injector.exe", QIODevice::ReadOnly);
 	proc.waitForFinished();
+	bHookedSteam = false;
 }
 
 

diff --git a/GloSC_GameLauncher/GloSC_GameLauncher.vcxproj b/GloSC_GameLauncher/GloSC_GameLauncher.vcxproj
@@ -105,6 +105,7 @@
       <AdditionalLibraryDirectories>$(QTDIR)\lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
       <GenerateDebugInformation>false</GenerateDebugInformation>
       <AdditionalDependencies>qtmain.lib;Qt5Core.lib;Qt5Gui.lib;Qt5Widgets.lib;%(AdditionalDependencies)</AdditionalDependencies>
+      <UACExecutionLevel>RequireAdministrator</UACExecutionLevel>
     </Link>
   </ItemDefinitionGroup>
   <ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
@@ -122,6 +123,7 @@
       <AdditionalLibraryDirectories>$(QTDIR)\lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
       <GenerateDebugInformation>false</GenerateDebugInformation>
       <AdditionalDependencies>qtmain.lib;Qt5Core.lib;Qt5Gui.lib;Qt5Widgets.lib;%(AdditionalDependencies)</AdditionalDependencies>
+      <UACExecutionLevel>RequireAdministrator</UACExecutionLevel>
     </Link>
   </ItemDefinitionGroup>
   <ItemGroup>

diff --git a/SteamTarget/SteamTargetRenderer.cpp b/SteamTarget/SteamTargetRenderer.cpp
@@ -254,7 +254,7 @@ void SteamTargetRenderer::hookBindings()
 	dir = dir.mid(0, dir.lastIndexOf("\\"));
 
 	QProcess proc;
-	proc.setNativeArguments(" --process-name Steam.exe --module-name " + dir + "\\EnforceBindingDLL.dll --inject ");
+	proc.setNativeArguments(" --process-name Steam.exe --module-name \"" + dir + "\\EnforceBindingDLL.dll\" --inject ");
 	proc.start(dir + "\\Injector.exe", QIODevice::ReadOnly);
 	proc.waitForFinished();
 	if (QString::fromStdString(proc.readAll().toStdString()).contains("Successfully injected module!")) //if we have injected (and patched the function)