add meta_programming's markup #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khusnetdinov
requested changes
Jun 30, 2018
| <div class="code-block"> | ||
| <p class="spec-title spec-correct">Meta</p> | ||
| {% highlight ruby %} | ||
|
|
There was a problem hiding this comment.
Проверь тут пробелы блоков в начале и после, не уверен что они есть в Gotcha
| define_method :bar do | ||
| puts 'This is a dynamic method' | ||
| end | ||
| end |
There was a problem hiding this comment.
После строку пустую, не надо лепить код. Места много
| create_method :foo | ||
| create_method :bar | ||
| create_method :baz | ||
| end |
| create_method :baz | ||
| end | ||
| Bar.new.my_foo | ||
| # => "Dynamic method called 'my_foo'" |
There was a problem hiding this comment.
Вот тут надо пробелами разделть код и коментарий, который относится к блоку. И ниже все
| # Parse another class for data | ||
| class AnotherClass | ||
| def get_foo_stuff; end | ||
|
|
There was a problem hiding this comment.
Давай пусты методы тоже без пробельных строк как хуки
| puts "Dynamic method called 'my_#{method}'" | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
строка после класса и везде ниже
|
@denver411 Денис, ветка твои должна называться #{Номер задачи}_#{Название задачи} Передалай |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Пробная верстка раздела meta programming