Merge pull request esoxjem#71 from Ali-Rezaei/IdlingResource

Fix a crash when user displays favourites while no movie is selected
kibichii-icode · Jun 5, 2018 · 8ee13bf · 8ee13bf
2 parents 7da6ea9 + 162518d
commit 8ee13bf
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/app/src/main/java/com/esoxjem/movieguide/listing/MoviesListingPresenterImpl.java b/app/src/main/java/com/esoxjem/movieguide/listing/MoviesListingPresenterImpl.java
@@ -43,6 +43,11 @@ private void displayMovies() {
         fetchSubscription = moviesInteractor.fetchMovies(currentPage)
                 .subscribeOn(Schedulers.io())
                 .observeOn(AndroidSchedulers.mainThread())
+                .doFinally(() -> {
+                    if (!EspressoIdlingResource.getIdlingResource().isIdleNow()) {
+                        EspressoIdlingResource.decrement(); // Set app as idle.
+                    }
+                })
                 .subscribe(this::onMovieFetchSuccess, this::onMovieFetchFailed);
     }
 
@@ -69,7 +74,6 @@ private void showLoading() {
     }
 
     private void onMovieFetchSuccess(List<Movie> movies) {
-        EspressoIdlingResource.decrement();
         if (moviesInteractor.isPaginationSupported()) {
             loadedMovies.addAll(movies);
         } else {
@@ -81,7 +85,6 @@ private void onMovieFetchSuccess(List<Movie> movies) {
     }
 
     private void onMovieFetchFailed(Throwable e) {
-        EspressoIdlingResource.decrement();
         view.loadingFailed(e.getMessage());
     }