deprecating strided_span

kileven · Oct 2, 2019 · eb995b3 · eb995b3
1 parent e026971
commit eb995b3
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/include/gsl/multi_span b/include/gsl/multi_span
@@ -1781,7 +1781,7 @@ GSL_SUPPRESS(bounds.4) // NO-FORMAT: attribute
 // strided_span is an extension that is not strictly part of the GSL at this time.
 // It is kept here while the multidimensional interface is still being defined.
 template <typename ValueType, std::size_t Rank>
-class strided_span
+class [[deprecated]] strided_span
 {
 public:
     using bounds_type = strided_bounds<Rank>;

diff --git a/tests/bounds_tests.cpp b/tests/bounds_tests.cpp
@@ -17,7 +17,9 @@
 #ifdef _MSC_VER
 // blanket turn off warnings from CppCoreCheck from catch
 // so people aren't annoyed by them when running the tool.
-#pragma warning(disable : 26440 26426 4996) // from catch deprecated
+#pragma warning(disable : 26440 26426) // from catch
+#pragma warning(disable : 4996)  // use of function or classes marked [[deprecated]]
+
 #endif
 
 #include <catch/catch.hpp> // for AssertionHandler, StringRef, TEST_CASE

diff --git a/tests/multi_span_tests.cpp b/tests/multi_span_tests.cpp
@@ -17,7 +17,9 @@
 #ifdef _MSC_VER
 // blanket turn off warnings from CppCoreCheck from catch
 // so people aren't annoyed by them when running the tool.
-#pragma warning(disable : 26440 26426 4996) // from catch deprecated
+#pragma warning(disable : 26440 26426) // from catch 
+#pragma warning(disable : 4996) // multi_span is in the process of being deprecated. 
+                                // Suppressing warnings until it is completely removed
 
 #endif
 

diff --git a/tests/strided_span_tests.cpp b/tests/strided_span_tests.cpp
@@ -17,7 +17,9 @@
 #ifdef _MSC_VER
 // blanket turn off warnings from CppCoreCheck from catch
 // so people aren't annoyed by them when running the tool.
-#pragma warning(disable : 26440 26426 4996) // from catch deprecated
+#pragma warning(disable : 26440 26426) // from catch deprecated
+#pragma warning(disable : 4996) // strided_span is in the process of being deprecated. 
+                                // Suppressing warnings until it is completely removed
 
 #endif