Skip to content

Commit

Permalink
*: update to go 1.14
Browse files Browse the repository at this point in the history
* Update to go 1.14
* Update golangci-lint to v1.23.6 that works with go 1.14
  • Loading branch information
sgotti committed Mar 20, 2020
1 parent f512d7e commit 771a8d3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .agola/config.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ local task_integration_tests(store, pgversion, arch) = {
},
],
depends: [
'build go 1.13 ' + arch,
'build go 1.14 ' + arch,
],
};

Expand Down Expand Up @@ -165,7 +165,7 @@ local task_build_push_images(name, pgversions, istag, push) =
[
task_build_go(version, arch),
]
for version in ['1.12', '1.13']
for version in ['1.13', '1.14']
for arch in ['amd64' /*, 'arm64' */]
]) + std.flattenArrays([
[
Expand Down
2 changes: 1 addition & 1 deletion examples/kubernetes/image/docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ARG PGVERSION

# base build image
FROM golang:1.13-buster AS build_base
FROM golang:1.14-buster AS build_base

WORKDIR /stolon

Expand Down
6 changes: 3 additions & 3 deletions test
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ echo "Running tests..."

COVER=${COVER:-"-cover"}

# Use only of specific go version to run gofmt since it'll break when we'll use go 1.10 and go 1.11
GOFMT_VERSION="go1.13"
# Use only of specific go version to run gofmt since it'll break when some formatting rules change between versions
GOFMT_VERSION="go1.14"

MAJOR_GOVERSION=$( echo -n $(go version) | grep -o 'go1\.[0-9]*' || true )
if [ "${MAJOR_GOVERSION}" == "${GOFMT_VERSION}" ]; then
Expand Down Expand Up @@ -76,7 +76,7 @@ fi


echo "Checking with golangci-lint"
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b ${BINDIR} v1.21.0
curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b ${BINDIR} v1.23.6
${BINDIR}/golangci-lint run --deadline 5m

echo "Running tests"
Expand Down

0 comments on commit 771a8d3

Please sign in to comment.