Skip to content

Commit

Permalink
Fix flaky test
Browse files Browse the repository at this point in the history
Assertation could be false if the server responds quickly enough (it's
unlikely to). Removing the assert does not change the nature of the
test.
  • Loading branch information
ctiller committed Jun 22, 2015
1 parent 8222b19 commit 8cca469
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/cpp/end2end/client_crash_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,8 @@ TEST_F(CrashTest, KillAfterWrite) {

KillServer();

EXPECT_FALSE(stream->Read(&response));
// This may succeed or fail depending on how quick the server was
stream->Read(&response);

EXPECT_FALSE(stream->Finish().ok());
}
Expand Down

0 comments on commit 8cca469

Please sign in to comment.