Fix #89 endless loop between container and no container since 3.4.0 #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 5, 2019 15:14
Passing the openerTabId without a cookieStoreId creates a tab in the same container as the opener. This isn't what we want when the tab is supposed to be opened without a container. In the latter case we simply attempt to update the tab after creation. #89 - Endless loop between container and no container since 3.4.0
#89 - Endless loop between container and no container since 3.4.0
ghost
deleted the
_#89_-_endless_loop_between_container_and_no_container_since_3.4.0_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes openerTabId only for new tabs in a container
Passing the openerTabId without a cookieStoreId creates a tab in the same container as the opener. This isn't what we want when the tab is supposed to be opened without a container.
We would try to create a new tab without a container, fail and retry ad infinitum.
In this case we simply attempt to update the tab with the openerId after creation without passing it at creation time
Closes #89