update: numpy, pandas, sdl2
#3164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Dynamos
force-pushed
the
numpy-update
branch
4 times, most recently
from
40f08b6 to
a09a2b3
Compare
T-Dynamos
force-pushed
the
numpy-update
branch
2 times, most recently
from
e950baa to
1cd30ca
Compare
|
Ready for review. Hope it can be merged soon! (One action failed, probably due to an internet connection error) |
AndreMiras
reviewed
Jun 20, 2025
AndreMiras
reviewed
Jun 20, 2025
AndreMiras
reviewed
Jun 20, 2025
AndreMiras
reviewed
Jun 24, 2025
| @@ -141,7 +141,6 @@ class Python3Recipe(TargetPythonRecipe): | |||
|
|
|||
| site_packages_dir_blacklist = { | |||
| '__pycache__', | |||
| 'tests' | |||
There was a problem hiding this comment.
Why do we keep tests in site packages? Or is it already handled upstream and no longer part of it?
There was a problem hiding this comment.
numpy has some tests dir, without that import numpy as np fails.
There was a problem hiding this comment.
Thanks for the context. How about mutating/patching the recipe from numpy instead?
Because in the current approach we will end up impacting bundle size for everyone. Plus someone may add tests back to the blacklist not realizing numpy needs it. Having it handled within the numpy recipe would solve both issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3163
Split #3136