refactor: refactor AddPageToDatabase function to use Person struc…
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t instead of individual field parameters - Modify the `AddPageToDatabase` function to accept a `Person` struct parameter - Remove the individual field parameters in the `AddPageToDatabase` function and use the `Person` struct instead - Update the properties passed to the `AddPageToDatabase` function with the corresponding fields from the `Person` struct - Add the `Company` field to the `Person` struct - Retrieve the `Company` value from the page in the `createEntryFromPage` function - Remove the logging of individual field values and log the `Person` struct instead - Update the test case in `TestAddNotionDB` to pass a `Person` struct as a parameter to `AddPageToDatabase` - Add an empty line in `TestAddNotionDB` Signed-off-by: Evan Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t instead of individual field parameters
AddPageToDatabasefunction to accept aPersonstruct parameterAddPageToDatabasefunction and use thePersonstruct insteadAddPageToDatabasefunction with the corresponding fields from thePersonstructCompanyfield to thePersonstructCompanyvalue from the page in thecreateEntryFromPagefunctionPersonstruct insteadTestAddNotionDBto pass aPersonstruct as a parameter toAddPageToDatabaseTestAddNotionDB