Skip to content

Commit

Permalink
runtime: remove VDSO fallback test and benchmarks
Browse files Browse the repository at this point in the history
These tests assume that it is OK to switch between time implementations,
but the clock_gettime call uses CLOCK_MONOTONIC and the fallback call,
gettimeofday, uses CLOCK_REALTIME. Disabling the clock_gettime call means
that calls to nanotime will start returning very different values.
This breaks the new timer code, which assumes that nanotime will return
a consistently increasing value.

This test is not very useful in any case as it doesn't check the results.

Removing this file also removes BenchmarkTimeNow, which is a duplicate
of BenchmarkNow in the time package.

Updates golang#27707
Fixes golang#32109

Change-Id: I6a884af07f75822d724193c5eed94742f524f07d
Reviewed-on: https://go-review.googlesource.com/c/go/+/174679
Reviewed-by: Brad Fitzpatrick <[email protected]>
  • Loading branch information
ianlancetaylor committed May 27, 2019
1 parent d97bd5d commit 1531192
Showing 1 changed file with 0 additions and 63 deletions.
63 changes: 0 additions & 63 deletions src/runtime/vdso_linux_test.go

This file was deleted.

0 comments on commit 1531192

Please sign in to comment.