Revert artifact ID, use name?

kkpan11 · Feb 23, 2024 · 6742901 · 6742901
1 parent d6460a2
commit 6742901
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/.github/workflows/build_check.yml b/.github/workflows/build_check.yml
@@ -33,17 +33,16 @@ jobs:
 
     - name: Upload build
       uses: actions/upload-artifact@v4
-      id: artifact-upload-step
       with:
         name: ${{ matrix.project }}_${{ matrix.framework }}_${{ matrix.runtime }}_${{ matrix.conf }}
         path: ${{ matrix.project }}/bin/${{ matrix.conf }}/${{ matrix.framework }}/${{ matrix.runtime }}/publish/
 
     - name: Upload to rolling
-      uses: ncipollo/release-action@v1
+      uses: ncipollo/release-action@v1.14.0
       with:
         allowUpdates: True
-        artifacts: ${{ steps.artifact-upload-step.outputs.artifact-id }}
-        generateReleaseNotes: true
+        artifacts: '*${{ matrix.project }}_${{ matrix.framework }}_${{ matrix.runtime }}_${{ matrix.conf }}*'
+        generateReleaseNotes: True
         omitBody: True
         omitBodyDuringUpdate: True
         omitNameDuringUpdate: True

diff --git a/.github/workflows/build_ui.yml b/.github/workflows/build_ui.yml
@@ -40,22 +40,20 @@ jobs:
         
     - name: Upload build
       uses: actions/upload-artifact@v4
-      id: artifact-upload-step
       with:
         name: ${{ matrix.project }}_${{ matrix.framework }}_${{ matrix.runtime }}_${{ matrix.conf }}
         path: ${{ matrix.project }}/bin/${{ matrix.conf }}/${{ matrix.framework }}/${{ matrix.runtime }}/publish/
 
     - name: Upload to rolling
-      uses: ncipollo/release-action@v1
+      uses: ncipollo/release-action@v1.14.0
       with:
         allowUpdates: True
-        artifacts: ${{ steps.artifact-upload-step.outputs.artifact-id }}
-        generateReleaseNotes: true
+        artifacts: '*${{ matrix.project }}_${{ matrix.framework }}_${{ matrix.runtime }}_${{ matrix.conf }}*'
+        generateReleaseNotes: True
         omitBody: True
         omitBodyDuringUpdate: True
         omitNameDuringUpdate: True
         prerelease: True
-        removeArtifacts: True
         replacesArtifacts: True
         tag: "ui-rolling"
         updateOnlyUnreleased: True
diff --git a/CHANGELIST.md b/CHANGELIST.md
@@ -25,6 +25,7 @@
 - Attempt to add CD to existing actions
 - Try fixing the artifact upload
 - Use recommendation from upload-artifact
+- Revert artifact ID, use name?
 
 ### 3.1.1 (2024-02-20)