[pull] master from GNOME:master #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
It was first introduced in 131834d but was incomplete.
Even though the libgimp wrapper has annotations, it is still possible to pass a NULL font through, in Script-Fu for instance by not passing all arguments (and very likely in a plug-in by calling the PDB procedure directly rather). And unfortunately this would crash GIMP when it tries to work on the NULL font. Let's do some sanity check!
Since the move of GimpUnit from some weird int/enum mixed type into a proper object type, this was not usable anymore in Script-Fu. Functions like (gimp-text-layer-new) were therefore broken. It now works again.
This was removed by commit 38b18de because this operation doesn't exist anymore and was replaced years ago. Even though it was not wrong, let's be over-cautious rather than not enough. What if someone had still a binary of this old operation lying around? This doesn't cost much to keep it in the list, so let's just do it (with a comment to still document it doesn't even exist anymore).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )