[pull] master from GNOME:master #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ipe" This reverts commit 4b71ca6. Breaks on MacOS, see #12711.
This a bandaid for an issue on MacOS: an IO event is received that says a read pipe from a plugin has data, but the pipe is actually empty and reads hang, and hang the app. Possibly this is an issue with GLib and could be fixed there, to not send such a spurious IO event. Possibly an alternative fix is to determine whether the app side of the plugin protocol is in a state where no messages from the plugin are expected. In that case, the read pipe should be flushed i.e. data discarded, with non-blocking reads, until a read returns nothing.
This fix does not cause the problems that the alternative fix caused (as detailed in #12898).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )