[pull] master from GNOME:master #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
added 2 commits
February 28, 2025 11:08
Fixes: > warning: variable 'n_children' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
…ider the item group. If you were to select a layer group and some/all its children, current implementation was "flattening" all these at the same level, which is weird. Now the whole questioning of what to do in this situation is a very good UX discussion to have, in particular when you only select *some* (not all) of the children. Does it mean something? Does it mean you want to copy part of the tree structure with only part of the children? What when it's not a copy, but a move (e.g. a dnd in the same image). You can't move part of the children (what do you do with the rest?). Anyway that's many questions which I prefer to leave for a real gimp-ux discussion and specification. For the time being, at least not flattening a whole tree structure seems a better behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )