[pull] master from GNOME:master #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Resolves #12967 In cdd5174, we added a destructive option for filters. Since toggling this moves the filter to the bottom of the stack, we refresh the layer. However, layer masks and channels can not yet have filters applied non-destructively, so this code created unnecessary undo history items when commited. This patch adds a check so that we only refresh layers and layer groups for now. Once we have NDE filters for layer masks/channels, we should revisit this code.
Resolves #13073 This patch adds a check to make sure we're not writing beyond the bounds of the "pos" array. This is the same check that we do earlier when writing pos[xc++], but it was left off of the last write command. Since "n" will be 0 if we get to the end of the array, it prevents us from writing beyond that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )